Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for deno compile with statically analyzable dynamic imports #17908

Closed
dsherret opened this issue Feb 24, 2023 · 0 comments · Fixed by #17663 or #18017
Closed

Add integration test for deno compile with statically analyzable dynamic imports #17908

dsherret opened this issue Feb 24, 2023 · 0 comments · Fixed by #17663 or #18017
Labels
chore something that we should get around to eventually

Comments

@dsherret
Copy link
Member

This works in 1.31.0, but we didn't add an integration test because it started working as part of an eszip upgrade (denoland/eszip#115).
@dsherret dsherret added the chore something that we should get around to eventually label Feb 24, 2023
@dsherret dsherret mentioned this issue Feb 24, 2023
Merged
@dsherret dsherret mentioned this issue Mar 5, 2023
Merged
dsherret pushed a commit that referenced this issue Mar 5, 2023
@andreubotella
test(compile): Add a test for dynamic imports in deno compile (#18017)
01028fc 
denoland/eszip#115 added support for statically-analyzed dynamic imports
in eszip, which made `deno compile` support dynamic imports starting
from #17858. This PR adds a test for it.

----

This test is adapted from PR #17663.

Closes #17908
kt3k pushed a commit that referenced this issue Mar 10, 2023
@andreubotella @kt3k
test(compile): Add a test for dynamic imports in deno compile (#18017)
c58790e 
denoland/eszip#115 added support for statically-analyzed dynamic imports
in eszip, which made `deno compile` support dynamic imports starting
from #17858. This PR adds a test for it.

----

This test is adapted from PR #17663.

Closes #17908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore something that we should get around to eventually
Projects
None yet
Milestone
No milestone
1 participant
@dsherret