Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno fmt breaks code when formatting file with unterminated string literal #23438

Closed
lucacasonato opened this issue Apr 18, 2024 · 1 comment · Fixed by #23449
Closed

deno fmt breaks code when formatting file with unterminated string literal #23438

lucacasonato opened this issue Apr 18, 2024 · 1 comment · Fixed by #23449
Labels
bug Something isn't working correctly deno fmt Related to the "deno fmt" subcommand or dprint

Comments

@lucacasonato
Copy link
Member

Version: Deno 1.42.3

var foo = 'bar
var foo = "ba";

Note how the r got lost. We should have just errored here that the file has unrecoverable invalid syntax
@lucacasonato lucacasonato added bug Something isn't working correctly deno fmt Related to the "deno fmt" subcommand or dprint labels Apr 18, 2024
@dsherret dsherret changed the title deno fmt breaks code when formatting file with syntax error deno fmt breaks code when formatting file with unterminated string literal Apr 18, 2024
@dsherret
Copy link
Member

dprint/dprint-plugin-typescript#628

@dsherret dsherret mentioned this issue Apr 18, 2024
Merged
dsherret added a commit that referenced this issue Apr 19, 2024
@dsherret
fix(fmt): error for more unterminated nodes (#23449)
90688ed 
dprint/dprint-plugin-typescript#628

Closes #23438
littledivy pushed a commit to littledivy/deno that referenced this issue Apr 19, 2024
@dsherret @littledivy
fix(fmt): error for more unterminated nodes (denoland#23449)
a6ca3a9 
dprint/dprint-plugin-typescript#628

Closes denoland#23438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly deno fmt Related to the "deno fmt" subcommand or dprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(fmt): error for more unterminated nodes dsherret/deno
2 participants
@dsherret @lucacasonato