globbing support when type checking

[FND]

As far as I can tell, deno check expects a file as entry point; it does not support targeting directories (failing silently; i.e. this limitation isn't obvious). Globbing might be used instead, but appears to be unsupported - unlike with adjacent commands (cf. #19102), which seems like a confusing inconsistency.

Thus projects without an obvious entry point covering all code (e.g. libraries with independent modules) need an out-of-band solution for module discovery, often resulting in shell scripts with limited portability.

Ideally, check should work just like lint, fmt and test:

$ deno lint "./src/**/*.ts"
$ deno check "./src/**/*.ts"

Perhaps it should also support targeting directories, though that might be a separate issue.

(For additional context, I've started documenting the way I've come to appreciate Deno as general-purpose tooling even beyond Deno-as-runtime projects, notably for client-side code.)

Version: Deno 1.45.2

[yazan-abdalrahman]

@lucacasonato @FND
can you explain the problem more, I'm still not sure I understand the requirement.

[marvinhagemeister]

@yazan-abdalrahman The deno check command doesn't do glob expansion. The issue is asking for supporting glob expansion there. Right now it treats glob paths as a literal file argument, which is wrong.

deno check "**/*.ts"
error: Module not found "file:///Users/marvinh/dev/denoland/docs/**/*.ts".

Instead, it should type check all files that match the glob pattern. In this case that would be all files in the current directory and below that end with .ts.

[yazan-abdalrahman]

@marvinhagemeister

ok I got it,

But for "lint" I think this wrong?
it's need deno.json
or it's another issue?

[marvinhagemeister]

That's odd, I'm not getting the error for lint on my mac. Maybe it's an OS issue?

[yazan-abdalrahman]

That's odd, I'm not getting the error for lint on my mac. Maybe it's an OS issue?

its needs some configuration <deno.json> ?

[yazan-abdalrahman]

@marvinhagemeister
@lucacasonato

that's correct ?

[marvinhagemeister]

Lgtm. The error is expected as using JSX is only valid inside .jsx/.tsx files.

[yazan-abdalrahman]

Lgtm. The error is expected as using JSX is only valid inside .jsx/.tsx files.

yes

[FND]

Looking good with Deno 1.46 - thank you all!