Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AbortSignals in addEventListeners options for EventTarget #8606

Closed
linux-china opened this issue Dec 3, 2020 · 2 comments · Fixed by #8616
Closed

Support AbortSignals in addEventListeners options for EventTarget #8606

linux-china opened this issue Dec 3, 2020 · 2 comments · Fixed by #8616

Comments

@linux-china
Copy link
Contributor

Source from whatwg/dom#911

const abortController = new AbortController();
const {signal} = abortController; 

const et = new EventTarget();
et.addEventListener('foo', (e) => {

}, { signal } );
@bartlomieju
Copy link
Member

CC @benjamingr

@benjamingr
Copy link
Contributor

I am happy to do this for deno, sure.

benjamingr added a commit to benjamingr/deno that referenced this issue Dec 4, 2020
@benjamingr
feat(op_crates/web) EventTarget signal support
857f18f 
Fixes: denoland#8606
@benjamingr benjamingr mentioned this issue Dec 4, 2020
Merged
@ry ry closed this as completed in #8616 Dec 4, 2020
ry pushed a commit that referenced this issue Dec 4, 2020
@benjamingr
feat(op_crates/web) EventTarget signal support (#8616)
71ef5a9 
Fixes: #8606
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 21, 2021
@benjamingr
feat(op_crates/web) EventTarget signal support (denoland/deno#8616)
1415599 
Fixes: denoland/deno#8606
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 24, 2021
@benjamingr
feat(op_crates/web) EventTarget signal support (denoland/deno#8616)
07c09b6 
Fixes: denoland/deno#8606
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 24, 2021
@benjamingr @caspervonb
feat(op_crates/web) EventTarget signal support (denoland/deno#8616)
1f53a15 
Fixes: denoland/deno#8606
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 24, 2021
@benjamingr @caspervonb
feat(op_crates/web) EventTarget signal support (denoland/deno#8616)
3187456 
Fixes: denoland/deno#8606
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 31, 2021
@benjamingr @caspervonb
feat(op_crates/web) EventTarget signal support (denoland/deno#8616)
d2b2077 
Fixes: denoland/deno#8606
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 31, 2021
@benjamingr @caspervonb
feat(op_crates/web) EventTarget signal support (denoland/deno#8616)
f6068bb 
Fixes: denoland/deno#8606
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 31, 2021
@benjamingr @caspervonb
feat(op_crates/web) EventTarget signal support (denoland/deno#8616)
f680fc6 
Fixes: denoland/deno#8606
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 31, 2021
@benjamingr @denobot
feat(op_crates/web) EventTarget signal support (denoland/deno#8616)
2535ef9 
Fixes: denoland/deno#8606
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Feb 1, 2021
@benjamingr @denobot
feat(op_crates/web) EventTarget signal support (denoland/deno#8616)
157d495 
Fixes: denoland/deno#8606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(op_crates/web) EventTarget signal support benjamingr/deno
3 participants
@linux-china @benjamingr @bartlomieju