build: make cargo check pass
#1125
Conversation
|
|
||
| let out_dir = env::var("OUT_DIR").unwrap(); | ||
| let out_dir = Path::new(&out_dir); | ||
| let wrapper_rs = out_dir.join("find_msg_generated.inc.rs"); |
There was a problem hiding this comment.
Impressively professional
- Can you add
cargo checkto travis and/or appveyor to ensure we maintain this. Can you add#[link(name = "libdeno", kind = "static", filename = OUT_DIR/libdeno.a )]insrc/libdeno.rs- I'm getting this error
~/src/deno> cargo build
Compiling idna v0.1.5
Compiling msg_rs v0.0.0 (file:///Users/rld/src/deno/msg_rs)
Compiling h2 v0.1.12
Compiling webpki v0.18.1
error: couldn't read "/Users/rld/src/deno/out/debug/gen/msg_generated.rs": No such file or directory (os error 2)
--> /Users/rld/src/deno/target/debug/build/msg_rs-f405e9593a5a6ae1/out/find_msg_generated.inc.rs:3:11
|
3 | mod msg;
| ^^^
error: aborting due to previous error
error: Could not compile `msg_rs`.
warning: build failed, waiting for other jobs to finish...
error: build failed
Error 101 ~/src/deno>
|
I was able to fix this by doing this: Please rename Does msg_rs really need to be its own crate? This is something that can be dealt with in a follow up, but we should be able to just import it was as module... |
piscisaureus
force-pushed
the
cargocheck
branch
4 times, most recently
from
156ab9d to
3fd62a0
Compare
ok, done
That's expected -- build.rs makes no attempt to build or run flatc to generate
done
I don't think so necessarily -- although what's nice now is that this hackery is confined in it's own little box. Prefer to deal with this in a follow up PR indeed. |
piscisaureus
force-pushed
the
cargocheck
branch
from
3fd62a0 to
9dcde71
Compare
|
@ry ptal |
|
@piscisaureus Please look at #1127 - upgrading flatbuffer coincidentally necessitated making msg_generated.rs a "mod" instead of a crate. I think we should land that first, since there's some complexity in your patch which will not exist after #1127 |
.cargo/config
Outdated
| # The location of the cargo build directory can be overridden, but the name of | ||
| # the directory itself is best left at 'target'. | ||
| # https://github.com/rust-lang/cargo/pull/1657#issue-36459101 | ||
| target-dir = "out/target" |
There was a problem hiding this comment.
If possible, let's leave this file out for now.
Starting a path with a slash is equivalent to specifying '**/the_path'. Removed the leading slash where it seemed unintentional.
|
Postponed to 2020. |
|
I'm resurrecting this in #1128 |
- Based on code from @qti3e and @piscisaureus in denoland#724 and denoland#1125 respectively. - TODO The DENO_BUILD_PATH env var must be supplied and must be an absolute path, this restriction should be removed in future work.
- Based on code from @qti3e and @piscisaureus in denoland#724 and denoland#1125 respectively. - TODO The DENO_BUILD_PATH env var must be supplied and must be an absolute path, this restriction should be removed in future work.
- Based on code from @qti3e and @piscisaureus in denoland#724 and denoland#1125 respectively. - TODO The DENO_BUILD_PATH env var must be supplied and must be an absolute path, this restriction should be removed in future work.
- Based on code from @qti3e and @piscisaureus in denoland#724 and denoland#1125 respectively. - TODO The DENO_BUILD_PATH env var must be supplied and must be an absolute path, this restriction should be removed in future work.
- Based on code from @qti3e and @piscisaureus in #724 and #1125 respectively. - TODO The DENO_BUILD_PATH env var must be supplied and must be an absolute path, this restriction should be removed in future work.
No description provided.