Use prebuilt v8 binaries #1217
Merged
Use prebuilt v8 binaries #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
force-pushed
the
prebuilt_v8
branch
9 times, most recently
from
1353441 to
e2d397a
Compare
|
i think this will be helpful for going towards |
ry
force-pushed
the
prebuilt_v8
branch
3 times, most recently
from
11a5e93 to
5a031ef
Compare
This still retains the ability to build V8 from scratch, with an number of configurations. The prebuilt binaries were created using DENO_BUILD_MODE=release ./tools/build.py v8
piscisaureus
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
I'm not so sure whether using gcloud to host the files is really the way to go forward.
Sure it's nice that we can reuse gclient to download the file, but we do now carry a homegrown upload tool.
Also it'd be more ideal to build & upload v8 using travis/appveyor in a similar way we publish deno itself; this makes upgrading less work for us and avoids the inevitable mistakes that we'll make when building v8 manually.
That said, I think we can move forward with this. Please address the one commit comment I made, other than that LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This retains our ability to build from scratch but will allow us to speed up CI / simplify dev built setups. This is work towards #1209