feat(serde_v8): support BigInt serialization #18225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables serializing `v8::BigInt` to `num_bigint::BigInt` in Rust.
lucacasonato
force-pushed
the
serde_v8_bigint
branch
from
b5a259a to
7951026
Compare
littledivy
reviewed
Mar 16, 2023
serde_v8/magic/bigint.rs
Outdated
| let v8bigint = v8::Local::<v8::BigInt>::try_from(value) | ||
| .map_err(|_| Error::ExpectedBigInt)?; | ||
| let word_count = v8bigint.word_count(); | ||
| let mut words = vec![0; word_count]; |
@littledivy because we already support i64, and i64 is limited to fixed width 8 byte integers, and this specific thing is encoding a variable size integer. This could be a |
littledivy
approved these changes
Mar 16, 2023
hardfist
pushed a commit
to hardfist/deno
that referenced
this pull request
Aug 7, 2024
This commit enables serializing `v8::BigInt` to `num_bigint::BigInt` in Rust. Pre-requisite for sub upcoming feature work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables serializing
v8::BigInttonum_bigint::BigIntin Rust.
Pre-requisite for sub upcoming feature work.