perf(core) Reduce script name and content copies #18298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
changed the title
mmastrac
changed the title
mmastrac
commented
Mar 21, 2023
mmastrac
changed the title
bartlomieju
reviewed
Mar 21, 2023
mmastrac
changed the title
bartlomieju
reviewed
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the number of copies and allocations of script code by carrying around ownership/reference information from creation time.
As an advantage, this allows us to maintain the identity of
&'static str-based scripts and use v8's external 1-byte strings (to avoid incorrectly passing non-ASCII strings, debugassert!s gate all string reference paths).Benchmark results:
Perf improvements -- ~0.1 - 0.2ms faster, but should reduce garbage w/external strings and reduces data copies overall. May also unlock some more interesting optimizations in the future.
This requires adding some generics to functions, but manual monomorphization has been applied (outer/inner function) to avoid code bloat.