Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include error in message about not being able to create the TypeScript cache #18356

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

dsherret
Copy link
Member

This failed locally for me when running the watcher tests for 15 minutes in multiple processes. I think maybe it's just my file system not being able to handle it... perhaps a fix would be to retry a couple times? Anyway, this fix just includes the error in the message, which in my case was "Access is denied (os error 5)"

---- integration::watcher::lint_all_files_on_each_change_test stdout ----
STDERR: error: Could not create TypeScript compiler cache location: C:\Users\david\AppData\Local\Temp\deno-cli-test-1679502655449-36\gen
STDERR: Check the permission of the directory.
STDERR: Access is denied. (os error 5)

Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@dsherret dsherret merged commit 1f635b1 into denoland:main Mar 22, 2023
@dsherret dsherret deleted the show_error_cant_create_cache branch March 22, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants