Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm64 build process for ci #1887
Arm64 build process for ci #1887
Changes from 41 commits
620c3eb
adbf4f8
6364e4c
ed23bab
759e931
9f1c739
c518671
eb861f5
8912aff
fdee970
a60d530
6f3d673
de65454
d25e5d1
9804a92
282f994
d34d3da
d932d13
0b129ea
99c0379
1476ec4
92e35f2
bd09e94
4852932
49dab37
cde9b5b
1f42601
618d71c
cffa6c9
23bd502
cf7388a
732004c
316eca0
b4f0eb6
0e1a6e4
70c38b7
7cd3a2f
b5c0c45
4067dee
46927e7
7820d5f
136040d
420a0be
d97c1ff
844db3a
5ac3ed4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest
let is_cross_compile = env::var("TARGET") != env::var("HOST");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not have the intended effect. Some targets might vary from host, but will still be compatible with the host. I.E.
x86_64-unknown-linux-musl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_cross_compile
might be a bad name for this one.