-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(npm): run pre and post tasks if present #19178
fix(npm): run pre and post tasks if present #19178
Conversation
279c6d2
to
7b9443d
Compare
Amended a couple more test cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that ensure that pre-
and post-
scripts are not automatically run from deno.json
. This feature is fine for compatibility with npm, but I'm not in favor of adding it to Deno's tasks.
@bartlomieju the changes in this PR only affect scripts from |
16bce38
to
6229eef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @marvinhagemeister!
This PR optionally runs pre and posts tasks from
package.json
if available.Fixes #19157