Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): create node_modules/.deno/node_modules folder #19242

Merged
merged 2 commits into from
May 24, 2023

Conversation

dsherret
Copy link
Member

This is what pnpm does and we were missing it. It makes modules work which have a dependency on something, but don't say they have that dependency, but that dep is still in the tree somewhere.

@dsherret dsherret marked this pull request as ready for review May 24, 2023 18:35
@dsherret dsherret requested a review from bartlomieju May 24, 2023 18:35
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit ba6f573 into denoland:main May 24, 2023
@dsherret dsherret deleted the fix_node_modules_deno branch May 24, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants