Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compile): implicit read permission to npm vfs #19281

Merged
merged 2 commits into from
May 26, 2023
Merged

fix(compile): implicit read permission to npm vfs #19281

merged 2 commits into from
May 26, 2023

Conversation

dsherret
Copy link
Member

Closes #19280

@dsherret dsherret requested a review from bartlomieju May 26, 2023 15:47
bartlomieju
bartlomieju approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit d0c5ff4 into denoland:main May 26, 2023
@dsherret dsherret deleted the vfs_implicit_read_permissions branch May 26, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno compile should always grant permission to read from the npm vfs
2 participants
@dsherret @bartlomieju