chore: add deprecation notices to FsFile methods
#21701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Dec 26, 2023
| @@ -2275,6 +2275,9 @@ declare namespace Deno { | |||
| * file.close(); | |||
| * ``` | |||
| * | |||
| * @deprecated Use {@linkcode FsFile.writable} instead. | |||
| * {@linkcode FsFile.write} will be removed in v2.0.0. | |||
| * | |||
There was a problem hiding this comment.
Where's the issue about these being deprecated? Closest I can find is #9795, but that doesn't seem to be about removing the methods on here.
There was a problem hiding this comment.
Removing those types seems ok, but removing these runtime functions is going too far, IMO. These functions are useful and easy to use. Removing them is going to break a lot of code.
There was a problem hiding this comment.
I'm okay with whatever we go with. I just thought this might've been missed with the previous PR. For context, this PR originated from denoland/std#4021 (comment).
|
Closing as there are no plans to deprecate these methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.