Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unstable/tar): skip node_modules, .git, and config "exclude" #21816

Merged
merged 7 commits into from
Jan 8, 2024
Merged

fix(unstable/tar): skip node_modules, .git, and config "exclude" #21816

merged 7 commits into from
Jan 8, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jan 5, 2024

No description provided.

@dsherret dsherret requested a review from bartlomieju January 5, 2024 18:58
@dsherret dsherret marked this pull request as draft January 5, 2024 19:03
@dsherret
Copy link
Member Author

dsherret commented Jan 5, 2024

Actually, I forgot about making this one ignore the "excludes" in deno.json

@dsherret dsherret marked this pull request as ready for review January 8, 2024 21:06
@dsherret dsherret changed the title fix(unstable/tar): skip node_modules and .git folder fix(unstable/tar): skip node_modules, .git, and config excludes Jan 8, 2024
@dsherret dsherret changed the title fix(unstable/tar): skip node_modules, .git, and config excludes fix(unstable/tar): skip node_modules, .git, and config "exclude" Jan 8, 2024
bartlomieju
bartlomieju approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no comments 👍

@dsherret dsherret merged commit 0efb17b into denoland:main Jan 8, 2024
14 checks passed
@dsherret dsherret deleted the fix_zip_skip_node_modules_git_folder branch January 8, 2024 23:51
bartlomieju pushed a commit that referenced this pull request Jan 12, 2024
@dsherret @bartlomieju
fix(unstable/tar): skip node_modules, .git, and config "exclude" (#21816
0d37f40 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju