feat(cli): add support for jsxImportSourceTypes #23419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Apr 17, 2024
dsherret
reviewed
Apr 17, 2024
lucacasonato
force-pushed
the
jsx_import_source_types
branch
from
5c6d924 to
7e649d0
Compare
dsherret
reviewed
Apr 18, 2024
Signed-off-by: Luca Casonato <[email protected]>
Signed-off-by: Luca Casonato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
understand why LSP has special handling ofjsxImportSourcein compileroptions as compared to
deno checkensure that @jsxImportSourceTypes pragma works in LSP✅ensure that @jsxImportSourceTypes pragma works in✅deno checktests{ "compilerOptions": { "jsx": "react-jsx", "jsxImportSource": "npm:react@^18.3", "jsxImportSourceTypes": "npm:@types/react@^18.3" } }Closes #16653
Closes #18203
Closes #20455