Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(check): expose more globals from @types/node #26603

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

dsherret
Copy link
Member

Extracted out of #26558

Closes #26578

@dsherret dsherret merged commit 0e64163 into denoland:main Oct 28, 2024
17 checks passed
@dsherret dsherret deleted the fix_expose_types_node_globals branch October 28, 2024 21:43
bartlomieju pushed a commit that referenced this pull request Oct 29, 2024
@dmint789
Copy link

dmint789 commented Dec 7, 2024

Has this been released? I'm still getting the error in VS code when using the process global. I'm on Deno 2.1.1.

@dsherret
Copy link
Member Author

dsherret commented Dec 7, 2024

Works for me. Maybe open an issue?

image

@dmint789
Copy link

dmint789 commented Dec 7, 2024

Works for me. Maybe open an issue?

image

Does it work for you with process.env?

@dsherret
Copy link
Member Author

dsherret commented Dec 7, 2024

Yes. In your case, are you sure the @types/node package is being included?

image

@dmint789
Copy link

dmint789 commented Dec 8, 2024

Yes. In your case, are you sure the @types/node package is being included?

image

I tried adding that line at the top, but it's not helping, even though I have @types/node installed through my package.json (I'm using it, because I have a Next JS project). Attaching the screenshot below.

image

@dmint789
Copy link

@dsherret do you know how I could make this error go away? I'm on Deno 2.1.4 and it still happens.

@dsherret
Copy link
Member Author

Maybe provide a full reproducible reproduction with a github repo? Otherwise there's no way to help because it's not reproducible.

@dsherret
Copy link
Member Author

Also, it's best to do this in a github issue instead of an old merged pr.

@dmint789
Copy link

Maybe provide a full reproducible reproduction with a github repo? Otherwise there's no way to help because it's not reproducible.

I made a reproducible example in the original issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP shows error for the process object even with the no-process-globals rule disabled
3 participants