Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide hints in terminal errors for Node.js globals #26610

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

bartlomieju
Copy link
Member

Add info/hint for terminal errors related to Node.js globals:

  • __filename
  • __dirname
  • Buffer
  • global
  • setImmediate
  • clearImmediate

Closes #17494

Screenshot 2024-10-28 at 23 14 16

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@bartlomieju bartlomieju merged commit 484f8ca into denoland:main Oct 28, 2024
17 checks passed
@bartlomieju bartlomieju deleted the node_globals_hints branch October 28, 2024 23:56
bartlomieju added a commit that referenced this pull request Oct 29, 2024
Add info/hint for terminal errors related to Node.js globals:
- __filename
- __dirname
- Buffer
- global
- setImmediate
- clearImmediate

Closes #17494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When global Node.js objects are referenced, Deno should error out with a friendly error message
2 participants