Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Happy New Year 2025 #27509

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

petamoriken
Copy link
Contributor

@petamoriken petamoriken commented Dec 31, 2024

🎊

@dsherret
Copy link
Member

Happy new year!

Sorry, I think I caused some conflicts by merging the sort imports cargo fmt change. As part of this, could you remove the "All rights reserved." sentence from the copyright headers? It's shorter and less confusing.

@petamoriken petamoriken marked this pull request as draft December 31, 2024 18:32
@petamoriken petamoriken force-pushed the chore/happy-new-year-2025 branch from 80c230e to 073cd0b Compare December 31, 2024 18:40
@petamoriken petamoriken marked this pull request as ready for review December 31, 2024 18:40
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret enabled auto-merge (squash) December 31, 2024 18:42
@dsherret dsherret merged commit 8fb073d into denoland:main Dec 31, 2024
17 of 20 checks passed
@petamoriken petamoriken deleted the chore/happy-new-year-2025 branch January 1, 2025 02:15
@reneroth
Copy link

reneroth commented Jan 1, 2025

fwiw this is legally not required, and actually inaccurate. If there was no work done in 2025, 2025 is not the copyright year. You can update the year, if need be, when there are actually changes made to the file. (Copyright notices are also wholly unnecessary anyways, copyright protection applies without them.)

From a devops pov, this kills many benefits of git without any benefit whatsoever. Now there are 1190 files changed in a single commit, which can cause troubles or annoyances in many ways down the line.

Maybe it makes more sense to add a generic disclaimer like This file is part of deno. See LICENSE.md for details., if you really feel the need for one at all.
See these interesting posts from the python project on the matter:

If you insist on doing it, you could add it to all files (e.g. cargo configs are missing them), and use an en dash () instead of a minus (-) 😋

Screenshots to demonstrate one of the many annoying effects of this, no easy way to see at a glance "what has last happened":

After:
Screenshot 2025-01-01 at 13 28 19

Before:
Screenshot 2025-01-01 at 13 29 01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants