Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: prototype faster test runner #3344

Merged
merged 23 commits into from
Nov 15, 2019
Merged

Conversation

bartlomieju
Copy link
Member

No description provided.

@bartlomieju
Copy link
Member Author

@ry before this PR std test were run only with release build, now CI fails on std tests with debug build... Can this std_tests test be run only in release tests?

@ry
Copy link
Member

ry commented Nov 14, 2019

Yeah we can conditionally skip the std test if it’s a debug build. Please add a TODO to fix it.

cli/tests/std_tests.rs Outdated Show resolved Hide resolved
cli/tests/std_tests.rs Outdated Show resolved Hide resolved
@bartlomieju
Copy link
Member Author

bartlomieju commented Nov 15, 2019

Oh this is soooo cool

DEBUG RS - deno::isolate:294 - dyn_import specifier C:\Users\RUNNER~1\AppData\Local\Temp\.tmpGMWvcR\.deno.test.ts referrer file:///D:/a/deno/deno/std/testing/runner.ts 
DEBUG RS - deno_cli::state:310 - state permissions denied for dyn import "c:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.tmpGMWvcR\\.deno.test.ts"
DEBUG RS - deno::isolate:503 - dyn_import_done 0 Err(Some("permission denied"))
⚠️️  Granted write access to "C:\Users\RUNNER~1\AppData\Local\Temp\.tmpGMWvcR\.deno.test.ts"

std_tests are run with -A flag and even though dynamic permission is denied for just created file. Interesting...

EDIT: Looks like module specifier is bad (missing file://), I'm still debugging.

EDIT2: Well obviously file:// is missing 😅should work now, although it might be misleading to Windows users that they need to do await import("file://${filePath}") when dealing with disk prefixed paths

run: |
cd std
../target/release/deno test -A

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/ thank you

}

return testFile;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hack but let's just go with it for now. It's much better to have the std tests running in "cargo test"

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you very much for taking this on, Bartek

@ry ry merged commit 34ed16e into denoland:master Nov 15, 2019
@bartlomieju bartlomieju deleted the perf-dynamic_import branch November 15, 2019 18:34
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants