-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: prototype faster test runner #3344
Conversation
f334611
to
9155460
Compare
@ry before this PR std test were run only with release build, now CI fails on std tests with debug build... Can this |
Yeah we can conditionally skip the std test if it’s a debug build. Please add a TODO to fix it. |
04f9208
to
69346f7
Compare
Oh this is soooo cool
EDIT: Looks like module specifier is bad (missing EDIT2: Well obviously |
run: | | ||
cd std | ||
../target/release/deno test -A | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/ thank you
} | ||
|
||
return testFile; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a hack but let's just go with it for now. It's much better to have the std tests running in "cargo test"
This reverts commit 2aa3905.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you very much for taking this on, Bartek
Removes three CI jobs
Removes three CI jobs
Removes three CI jobs
Removes three CI jobs
Removes three CI jobs
Removes three CI jobs
Removes three CI jobs
Removes three CI jobs
Removes three CI jobs
Removes three CI jobs
No description provided.