BREAKING: remove support for JSON imports #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes support for importing JSON files as modules. This change is dictated by security; browsers rolled back on this support as well.
bartlomieju
commented
May 1, 2020
| @@ -118,8 +115,9 @@ impl GlobalState { | |||
| let compile_lock = self.compile_lock.lock().await; | |||
|
|
|||
| let compiled_module = match out.media_type { | |||
| msg::MediaType::Unknown => state1.js_compiler.compile(out).await, | |||
| msg::MediaType::Json => state1.json_compiler.compile(&out).await, | |||
| msg::MediaType::Json | msg::MediaType::Unknown => { | |||
There was a problem hiding this comment.
I think MediaType::Json could now be removed; it'd be handled as MediaType::Unknown
|
CC @kitsonk |
|
Closes #3401. |
|
There may be special handling of json imports in the bundler code base. |
bartlomieju
commented
May 1, 2020
Comment on lines
-398
to
-409
| #[test] | ||
| fn bundle_json() { | ||
| let json_modules = util::root_path().join("cli/tests/020_json_modules.ts"); | ||
| assert!(json_modules.is_file()); | ||
| let t = TempDir::new().expect("tempdir fail"); | ||
| let bundle = t.path().join("020_json_modules.bundle.js"); | ||
| let mut deno = util::deno_cmd() | ||
| .current_dir(util::root_path()) | ||
| .arg("bundle") | ||
| .arg(json_modules) | ||
| .arg(&bundle) | ||
| .spawn() |
There was a problem hiding this comment.
@ry thanks for pointing this out; I guess there should be permission check involved in this case like a regular disk read?
|
LGTM |
SASUKE40
pushed a commit
to SASUKE40/deno
that referenced
this pull request
May 7, 2020
This commit removes support for importing JSON files as modules. This change is dictated by security; browsers rolled back on this support as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes support for importing JSON files as modules.
This change is dictated by security; browsers rolled back the support.