refactor: pass hash into code cache #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
May 23, 2024
| @@ -275,7 +288,8 @@ impl ModuleLoader for MockLoader { | |||
|
|
|||
| fn code_cache_ready( | |||
| &self, | |||
| module_specifier: &ModuleSpecifier, | |||
| module_specifier: ModuleSpecifier, | |||
There was a problem hiding this comment.
Changed this to an owned value because deno_core has it available without cloning and this can help prevent cloning if someone wants to send this to another thread when saving the code cache.
| @@ -275,7 +288,8 @@ impl ModuleLoader for MockLoader { | |||
|
|
|||
| fn code_cache_ready( | |||
| &self, | |||
| module_specifier: &ModuleSpecifier, | |||
| module_specifier: ModuleSpecifier, | |||
| _hash: u64, | |||
| code_cache: &[u8], | |||
| ) -> Pin<Box<dyn Future<Output = ()>>> { | |||
There was a problem hiding this comment.
We should look into doing something similar for the script callbacks. I'm just not sure how to convert a Local<String> to a &str... maybe deno_core should just create the hash.
There was a problem hiding this comment.
You can convert it like so: &x.to_rust_string_lossy(scope)
bartlomieju
approved these changes
May 23, 2024
igorzi
reviewed
May 23, 2024
dsherret
added a commit
that referenced
this pull request
May 24, 2024
dsherret
added a commit
to denoland/deno
that referenced
this pull request
May 24, 2024
* denoland/deno_core#752 * denoland/deno_core#753 Did benchmarking on this and it's slightly faster (couple ms) or equal to in performance as main. Closes #23904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the cli having to re-lookup the hash again.