Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't report diagnostics on remote modules #403

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: don't report diagnostics on remote modules #403

merged 2 commits into from
Nov 30, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret requested a review from bartlomieju November 30, 2023 15:50
bartlomieju
bartlomieju approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 492fcd3 into denoland:main Nov 30, 2023
3 checks passed
@dsherret dsherret deleted the fix_ignore_remote_module_diagnostics branch November 30, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju