feat: dont underscore numbers when formatting module names #655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jsr-io/jsr#803 but I'd like to know how or if I could better test this.
I eventually got here by looking at how the identifier for the file was created:
![image](https://private-user-images.githubusercontent.com/55610086/384085506-b21cc148-384c-4b89-be2a-6cfe0f1b8e63.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNzEwMjMsIm5iZiI6MTczOTI3MDcyMywicGF0aCI6Ii81NTYxMDA4Ni8zODQwODU1MDYtYjIxY2MxNDgtMzg0Yy00Yjg5LWJlMmEtNmNmZTBmMWI4ZTYzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDEwNDUyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI0NzIxYTI1MTQwZmYxMGMyODhiZjZjMWM1ZTQ3YTMwZmRmZjNiMTI4NDdhMGVlZDc0YTA2YWZkYTFiZWE1YmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.LyyBAUeymdl7OXhfUvAEUY7hRE__muKAOB0a-AQ7AlM)
The identifier replacing all non-characters with underscores seems to be the source so adjusting the regex to allow numbers.
Though this regex might need to account for a leading number and replace that since you can't have a module identifier prefixed by a number (must be a character)