Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show private symbols in dts files #693

Merged
merged 4 commits into from
Jan 27, 2025
Merged

fix: show private symbols in dts files #693

merged 4 commits into from
Jan 27, 2025

Conversation

crowlKats
Copy link
Member

Also removes the "default" header in the all symbols page if its a single d.ts file

Comment on lines +806 to +808
pub fn is_internal(&self, ctx: &GenerateCtx) -> bool {
(self.inner.declaration_kind == crate::node::DeclarationKind::Private
&& !matches!(ctx.file_mode, FileMode::SingleDts | FileMode::Dts))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the main fix

Copy link

@thisisjofrank thisisjofrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@crowlKats crowlKats merged commit 697d274 into main Jan 27, 2025
5 checks passed
@crowlKats crowlKats deleted the dts-privates branch January 27, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants