Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use jsr:@cmd-johnson/oauth2-client #334

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Nov 25, 2024

Now, we no longer need to vendor the package, as it's on JSR.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (190853d) to head (189ba55).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files          24       24           
  Lines         583      583           
  Branches       32       32           
=======================================
  Hits          565      565           
  Misses         16       16           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Contributor Author

iuioiua commented Dec 16, 2024

PTAL @kt3k

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kt3k kt3k merged commit cffb13c into denoland:main Dec 17, 2024
8 checks passed
@iuioiua iuioiua deleted the use-@cmd-johnson/oauth2-client branch December 17, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants