-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(text): release [email protected]
#5209
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5209 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 463 463
Lines 37728 37728
Branches 5571 5571
=======================================
Hits 36354 36354
Misses 1332 1332
Partials 42 42 ☔ View full report in Codecov by Sentry. |
closestStringThis note sounds concerning to me when it comes to stabilization. I'd suggest that we pin the algorithm that this function internally uses to calculate similarity, or make it configurable by an optional parameter and default to Levenshtein if none is specified by a user. compareSimilarityditto wordSimilaritySOrtditto toCamelCaseThis is defined in The same goes for |
Maybe it's better to align to that rule in this case. @iuioiua Do you have any opinions? BTW there are multiple places where we break that rule. The examples are:
|
This sounds reasonable to me. Thanks for the suggestion! |
All good suggestions. Happy to proceed with them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
To be merged July 11.
The latest API docs: https://jsr.io/@std/[email protected]
Closes #4999