Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ulid): release [email protected] #5206

Merged
merged 3 commits into from
Jul 14, 2024
Merged

chore(ulid): release [email protected] #5206

merged 3 commits into from
Jul 14, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 1, 2024

To be merged July 10.

The latest API docs: https://jsr.io/@std/[email protected]/doc

Closes #4996

@iuioiua iuioiua requested a review from kt3k as a code owner July 1, 2024 03:23
@github-actions github-actions bot added the ulid label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (f54eab4) to head (91bdc0a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5206   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files         461      461           
  Lines       37762    37762           
  Branches     5576     5576           
=======================================
  Hits        36385    36385           
  Misses       1335     1335           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k requested a review from magurotuna July 10, 2024 04:59
@magurotuna
Copy link
Member

The only comment I have on this submodule is the same as the one I did on toCamelCase - we may want to import decodeTime with import { decodeTime } from "jsr:@std/ulid/decode-time" for instance.

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 14, 2024

PTAL now, @magurotuna.

Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iuioiua iuioiua merged commit 010784a into main Jul 14, 2024
16 checks passed
@iuioiua iuioiua deleted the ulid-1 branch July 14, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracking: stabilize ulid
2 participants