Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shim for URLPattern #417

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raaymax
Copy link

@raaymax raaymax commented Jul 7, 2024

Added shim for URLPattern using
https://www.npmjs.com/package/urlpattern-polyfill

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you be able to add an integration test in the tests folder? I've found it's good to have one for these shims.

@@ -13,6 +13,7 @@ Deno.test("should get when all true", () => {
crypto: true,
domException: true,
undici: true,
urlPattern: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should use a deno fmt to fix that tabulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants