Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to-do: investigate the viability of formatter option for assertEquals() #4891

Closed
iuioiua opened this issue May 29, 2024 · 1 comment
Closed
Assignees

Comments

@iuioiua
Copy link
Contributor

iuioiua commented May 29, 2024

We need to decide whether this option is to be kept before achieving stabilization. See documentation.

One clear point against it is that it's a fourth argument for assertEquals(), which goes against the Deno Style Guide of having two arguments and a third option argument, max (see https://docs.deno.com/runtime/manual/references/contributing/style_guide#exported-functions-max-2-args-put-the-rest-into-an-options-object). If we are to keep it, we should merge msg and formatter into a third options argument.

@kt3k
Copy link
Member

kt3k commented May 30, 2024

Looks like introduced in #3563 , but I don't remember well why this was needed.

I think we should remove that option. We didn't get any feedback about this option. I think nobody uses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants