We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formatter
assertEquals()
We need to decide whether this option is to be kept before achieving stabilization. See documentation.
One clear point against it is that it's a fourth argument for assertEquals(), which goes against the Deno Style Guide of having two arguments and a third option argument, max (see https://docs.deno.com/runtime/manual/references/contributing/style_guide#exported-functions-max-2-args-put-the-rest-into-an-options-object). If we are to keep it, we should merge msg and formatter into a third options argument.
msg
The text was updated successfully, but these errors were encountered:
Looks like introduced in #3563 , but I don't remember well why this was needed.
I think we should remove that option. We didn't get any feedback about this option. I think nobody uses it.
Sorry, something went wrong.
kt3k
iuioiua
No branches or pull requests
We need to decide whether this option is to be kept before achieving stabilization. See documentation.
One clear point against it is that it's a fourth argument for
assertEquals()
, which goes against the Deno Style Guide of having two arguments and a third option argument, max (see https://docs.deno.com/runtime/manual/references/contributing/style_guide#exported-functions-max-2-args-put-the-rest-into-an-options-object). If we are to keep it, we should mergemsg
andformatter
into a third options argument.The text was updated successfully, but these errors were encountered: