Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move _util/diff to assert/_diff #3563

Merged
merged 2 commits into from
Aug 23, 2023
Merged

refactor: move _util/diff to assert/_diff #3563

merged 2 commits into from
Aug 23, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Aug 22, 2023

No description provided.

bartlomieju
bartlomieju approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not super pretty but it solves the problem at hand nicely.

Can you remove _util/diff.ts in this PR as well?

@kt3k
Copy link
Member Author

kt3k commented Aug 22, 2023

Added formatter option instead of serialized option, and now assertEquals is less artificial in my view.

Can you remove _util/diff.ts in this PR as well?

_util/diff.ts is renamed to assert/_diff.ts

@kt3k kt3k requested a review from dsherret August 22, 2023 21:56
@kt3k kt3k mentioned this pull request Aug 22, 2023
Merged
@kt3k kt3k changed the title chore: move _util/diff to assert/_diff refactor: move _util/diff to assert/_diff Aug 22, 2023
@kt3k kt3k merged commit ee6856c into denoland:main Aug 23, 2023
@kt3k kt3k deleted the move-util-diff-to-assert branch August 23, 2023 07:45
This was referenced May 30, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kt3k @bartlomieju @iuioiua