Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node/events): addListener and removeListener methods should have the correct names #1094

Merged

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Aug 4, 2021

Part of #911

This PR enables test-event-emitter-method-names.js and fixes EventEmitter to align with it.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uki00a LGTM. Thanks!

@kt3k kt3k merged commit eaaf2ef into denoland:main Aug 5, 2021
@uki00a uki00a deleted the enable-test-event-emitter-method-names.js branch August 5, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants