feat(node/crypto): add scrypt and scryptSync
#1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 1, 2021 00:00
…-std-node-crypto-scrypt
…-std-node-crypto-scrypt
There should be relevant copyrights included in the source. |
|
@bartlomieju ok one sec will add a license comment |
|
done, @bartlomieju |
kt3k
approved these changes
Oct 2, 2021
There was a problem hiding this comment.
LGTM with nits. Nice work! @talentlessguy
Also confirmed the test cases match with Node.js results.
| @@ -0,0 +1,179 @@ | |||
| import { scrypt, scryptSync } from "./scrypt.ts"; | |||
There was a problem hiding this comment.
nit: This file needs copyright header
// Copyright 2018-2021 the Deno authors. All rights reserved. MIT license.
There was a problem hiding this comment.
Let's address this in another PR as we already have many files missing copyright headers.
There was a problem hiding this comment.
ok no problem
and thanks for merging!
deno_std/node/crypto is getting closer to node.js :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation borrowed from https://github.com/crypto-browserify/scrypt
deno fmtanddeno lint