feature(node/http): Export STATUS_CODES and METHODS #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UltiRequiem
changed the title
UltiRequiem
changed the title
|
This will be fixed once denoland/deno#12348 lands |
The problem persist
|
kt3k
reviewed
Oct 7, 2021
node/http.ts
Outdated
| @@ -1 +1,42 @@ | |||
| throw new Error('"http" is not yet implemented.'); | |||
| import { Status as STATUS_CODES } from "../http/mod.ts"; | |||
There was a problem hiding this comment.
Let's import from ../http/http_status.ts to avoid introducing the entire http dependency here
|
Thank you @bartlomieju for resolving a lot of CI failures in std! |
bartlomieju
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
https://nodejs.org/api/http.html#http_http_status_codes
https://nodejs.org/api/http.html#http_http_methods
I have run deno fmt and deno lint