Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(http/file_server): log add color and change log format #1434

Merged
merged 2 commits into from
Oct 20, 2021
Merged

add(http/file_server): log add color and change log format #1434

merged 2 commits into from
Oct 20, 2021

Conversation

xiaoxigua-1
Copy link
Contributor

@xiaoxigua-1 xiaoxigua-1 commented Oct 19, 2021 •
edited
Loading

Demo
image

@xiaoxigua-1 xiaoxigua-1 changed the title add(http): file server log add color and log format add(http): file server log add color and fix log format Oct 19, 2021
@xiaoxigua-1 xiaoxigua-1 changed the title add(http): file server log add color and fix log format add(http): file server log add color and change log format Oct 19, 2021
@xiaoxigua-1 xiaoxigua-1 changed the title add(http): file server log add color and change log format add(http/file_server): log add color and change log format Oct 20, 2021
@kt3k
Copy link
Member

kt3k commented Oct 20, 2021

Using red for errors make sense to me, but I think it's better to keep the default color for non error messages (blue might be hard to see depending on the terminal configuration)

@xiaoxigua-1
Copy link
Contributor Author

Using red for errors make sense to me, but I think it's better to keep the default color for non error messages (blue might be hard to see depending on the terminal configuration)

ok

@xiaoxigua-1
Copy link
Contributor Author

demo

image

kt3k
kt3k approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaoxigua-1 LGTM. Thanks!

@kt3k kt3k merged commit efd7583 into denoland:main Oct 20, 2021
traceypooh pushed a commit to traceypooh/deno_std that referenced this pull request Nov 14, 2021
@xiaoxigua-1 @traceypooh
feat(http/file_server): add color to log message (denoland#1434)
24d93f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoxigua-1 @kt3k