Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): add http.Agent #1706

Merged
merged 1 commit into from
Dec 16, 2021
Merged

feat(node): add http.Agent #1706

merged 1 commit into from
Dec 16, 2021

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Dec 14, 2021 •
edited
Loading

part of #1703
depends on #1705

This PR adds http.Agent class in std/node

@kt3k kt3k mentioned this pull request Dec 14, 2021
Closed
6 tasks
@kt3k kt3k force-pushed the feat/node-http-agent branch 2 times, most recently from d08c8e0 to 54b242e Compare December 14, 2021 07:04
@kt3k kt3k force-pushed the feat/node-http-agent branch from 54b242e to 36df7c9 Compare December 15, 2021 02:03
@kt3k kt3k marked this pull request as ready for review December 15, 2021 03:41
@kt3k kt3k mentioned this pull request Dec 15, 2021
Merged
bnoordhuis
bnoordhuis approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM. I recognize a lot of code from my Node days though. :-)

@kt3k kt3k merged commit 14f58c6 into denoland:main Dec 16, 2021
@kt3k kt3k deleted the feat/node-http-agent branch December 16, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @bnoordhuis