-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: streams based Buffer
#1970
Conversation
What's the use case for this? Why create a new class with the same name instead of adding this functionality to existing |
@bartlomieju well, we want various Deno.Reader/Writer based APIs to be written/ported to streams. These should be in their own file so there in no dependency on the aforementioned APIs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crowlKats Does this also allow for browser compatibility? If so, please mark it as such. |
@jsejcksn nope, once again, typescript is behind the times with outdated typings |
@crowlKats There's a tracking issue for compat issues caused by outdated native TS types here. Will you add any candidate modules there? |
@jsejcksn done |
Equivalent of
std/io/buffer.ts
'sBuffer
but with streams