fix(wasi): ContextOptions is an optional argument #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tani
changed the title
kt3k
reviewed
Apr 22, 2022
wasi/snapshot_preview1.ts
Outdated
| @@ -346,7 +346,7 @@ export default class Context { | |||
|
|
|||
| exports: Record<string, WebAssembly.ImportValue>; | |||
|
|
|||
| constructor(options: ContextOptions) { | |||
| constructor(options?: ContextOptions = {}) { | |||
There was a problem hiding this comment.
This seems throwing an type error
error: TS1015 [ERROR]: Parameter cannot have question mark and initializer.
constructor(options?: ContextOptions = {}) {
~~~~~~~
at file:///Users/runner/work/deno_std/deno_std/wasi/snapshot_preview1.ts:349:15
|
@kt3k Thank you for giving the review. I fixed it. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the node.js docs,
we can use WASI class without arguments. I mean that the
ContextOptionsshould be optional.This is a problematic to load https://github.com/ruby/ruby.wasm .
See also: https://nodejs.org/api/wasi.html