Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: serve() should export the interface ServeTlsInit #2148

Merged
merged 1 commit into from
Apr 24, 2022
Merged

http: serve() should export the interface ServeTlsInit #2148

merged 1 commit into from
Apr 24, 2022

Conversation

timonson
Copy link
Contributor

I would like to see ServeTlsInit being exported the way ServeInit already is.

@timonson
Export interface ServeTlsInit
312945a 
I would like to see `ServeTlsInit` being exported the way `ServeInit` already is.
@CLAassistant
Copy link

CLAassistant commented Apr 24, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

kt3k
kt3k approved these changes Apr 24, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as it is a part of already exported serveTls API.

@kt3k kt3k merged commit 0e74e21 into denoland:main Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timonson @CLAassistant @kt3k