Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node/worker_threads): Don't wait for parent message in web worker #2182

Merged
merged 3 commits into from
May 3, 2022

Conversation

nayeemrmn
Copy link
Contributor

@nayeemrmn nayeemrmn commented May 3, 2022

Fixes #2181. Uses a different method for detecting if the environment is in a node worker thread so that web workers don't count. That way it doesn't wait for a parent startup message that is never coming.

@nayeemrmn nayeemrmn requested review from bartlomieju and kt3k as code owners May 3, 2022 05:04
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit c19d014 into denoland:main May 3, 2022
@nayeemrmn nayeemrmn deleted the worker-thread-detection branch June 21, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node/module.ts hangs in a web worker
2 participants