fix(encoding/csv/stream): properly handle CR characters #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uki00a
commented
Jun 8, 2022
| @@ -34,64 +40,9 @@ Deno.test({ | |||
| }, | |||
| }); | |||
|
|
|||
| Deno.test({ | |||
There was a problem hiding this comment.
These behaviors are covered by the newly added test cases
uki00a
commented
Jun 8, 2022
| const textLine = new TextLineStream(); | ||
| this.#textLine = textLine; | ||
| this.#lineReader = new StreamLineReader(textLine.readable.getReader()); | ||
| this.#lines = new TextDelimiterStream("\n"); |
There was a problem hiding this comment.
Uses TextDelimiterStream because consecutive trailing CRs need to be kept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSVStreamhad a problem where CRs in fields and consecutive trailing CRs were not handled properly. This PR fixes that problem.The PR also adds some test cases.