feat(crypto): add subtle.timingSafeEqual() #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
subtle.timingSafeEqual()tostd/cryptowhich is used to compare array buffers in a way that cannot be exploited in timing based attacks.This is like to be added to WebCrypto at some point in the near future (see: w3c/webcrypto#270) but until that point, we should have it in std. It is required #2303 which I am refactoring as part of the migration of oak commons to std.
It also refactors
node/crypto/timingSafeEqualto use this instead of its own implementation (which is very close to this implementation, but supports Node.js'sBufferas well).