feat(async/delay): add persistent option #2527
Conversation
|
|
Right. Let's wrap it with type guard condition Also let's mention that the option depends on |
|
Another naming candidate for this option would be Which do you think is better? |
async/delay.ts
Outdated
| @@ -3,11 +3,13 @@ | |||
|
|
|||
| export interface DelayOptions { | |||
| signal?: AbortSignal; | |||
| /** Defines if the timer should be non-blocking. This is `false` by default. */ | |||
There was a problem hiding this comment.
the timer should be non-blocking sounds strange to me as timers are always async operations. I would document this like Indicates whether the process can exit while the timer still existing
There was a problem hiding this comment.
Another naming candidate for this option would be
persistent(with opposite effect of boolean value) as used infs.watchof node.js https://nodejs.org/api/fs.html#fswatchfilename-options-listenerWhich do you think is better?
Yeah, I like persistent.
fixed: default value
iuioiua
changed the title
async/delay.ts
Outdated
| /** Indicates whether the process can exit before the timer ends. This is `false` by default. */ | ||
| persistent?: boolean; |
There was a problem hiding this comment.
If we use persistent, then the meaning (effect) is the opposite of unref. The doc would be Indicates whether the process should continue to run as long as timer existing and it defaults to true.
There was a problem hiding this comment.
My misunderstanding. Fixed now!
|
Let's wait a little while to see if there's any concern on this addition |
For #1730. Am I right in saying a test can't currently be done for this?