Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(collections): deepMerge ignoring 'replace' options for nested properties #2681

Merged
merged 1 commit into from
Sep 22, 2022
Merged

fix(collections): deepMerge ignoring 'replace' options for nested properties #2681

merged 1 commit into from
Sep 22, 2022

Conversation

lowlighter
Copy link
Contributor

Fix #2673

kt3k
kt3k approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lowlighter Thanks for looking into this! LGTM

@kt3k kt3k merged commit fe23391 into denoland:main Sep 22, 2022
@lowlighter lowlighter deleted the codespace-a8f1 branch September 22, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deepMerge seems to ignore merge options on nested props
2 participants
@lowlighter @kt3k