test(node/fs): add test-fs-read-stream.js #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolarETech
commented
Sep 24, 2022
Comment on lines
+200
to
+209
| if (!common.isWindows) { | ||
| // Verify that end works when start is not specified, and we do not try to | ||
| // use positioned reads. This makes sure that this keeps working for | ||
| // non-seekable file descriptors. | ||
| tmpdir.refresh(); | ||
| const filename = `${tmpdir.path}/foo.pipe`; | ||
| const mkfifoResult = child_process.spawnSync('mkfifo', [filename]); | ||
| if (!mkfifoResult.error) { | ||
| child_process.exec(`echo "xyz foobar" > '${filename}'`); | ||
| const stream = new fs.createReadStream(filename, common.mustNotMutateObjectDeep({ end: 1 })); |
There was a problem hiding this comment.
The test item which uses child_process will not be executed on Windows. Therefore, there is no need to add this test to "windowsIgnore" in config.json, as the test will not fail due to escaping issue on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds parallel/test-fs-read-stream.js, which was waiting for
child_process.spawnSync()andchild_process.exec()implementation in #2653.