Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): new child_process.fork #2700

Merged
merged 9 commits into from
Sep 29, 2022
Merged

feat(node): new child_process.fork #2700

merged 9 commits into from
Sep 29, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 27, 2022

This PR enables child_process.fork based on --node-modules-dir flag and DENO_DONT_USE_INTERNAL_NODE_COMPAT_STATE env var.

( DENO_DONT_USE_INTERNAL_NODE_COMPAT_STATE feature is available on
this PR denoland/deno#15891 )

@kt3k kt3k mentioned this pull request Sep 27, 2022
Merged
dsherret
dsherret reviewed Sep 29, 2022
View reviewed changes
@kt3k kt3k marked this pull request as ready for review September 29, 2022 08:04
@kt3k kt3k requested a review from bartlomieju as a code owner September 29, 2022 08:04
@kt3k kt3k marked this pull request as draft September 29, 2022 09:31
@kt3k kt3k marked this pull request as ready for review September 29, 2022 10:40
@kt3k kt3k requested a review from dsherret September 29, 2022 10:41
dsherret
dsherret approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kt3k kt3k merged commit 1bbcae8 into denoland:main Sep 29, 2022
@kt3k kt3k deleted the new-child-process-fork branch September 29, 2022 16:31
@kt3k kt3k mentioned this pull request Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@cjihrig cjihrig cjihrig approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kt3k @dsherret @cjihrig