fix(node/fs): enable to check error thrown on invalid values of bufferSize #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
reviewed
Oct 17, 2022
node/_fs/_fs_opendir.ts
Outdated
Comment on lines
84
to
89
| if (options) { | ||
| ({ encoding = "utf8", bufferSize = 32 } = options); | ||
| } else { | ||
| encoding = "utf8"; | ||
| bufferSize = 32; | ||
| } |
There was a problem hiding this comment.
Node uses a utility function called getOptions() here. We have that here (although the second argument should be updated to default to kEmptyObject). I think it would be preferable to use that here.
There was a problem hiding this comment.
- use
getOptions() - use
validateIntegerinstead ofcheckBufferSize - delete
assertEncodingbecause called ingetOptions()
added 2 commits
October 18, 2022 22:32
wafuwafu13
requested review from
cjihrig
and removed request for
kt3k and
bartlomieju
cjihrig
reviewed
Oct 20, 2022
node/_fs/_fs_opendir.ts
Outdated
| assertEncoding(encoding); | ||
|
|
||
| checkBufferSize(bufferSize, "options.bufferSize"); | ||
| const { _encoding, bufferSize } = getOptions(options, { |
There was a problem hiding this comment.
We don't need to destructure _encoding out if it's not being used. Same comment below.
cjihrig
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: #911