Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(node/http): modify writable of ClientRequest #2945

Merged
merged 1 commit into from
Nov 26, 2022
Merged

test(node/http): modify writable of ClientRequest #2945

merged 1 commit into from
Nov 26, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Nov 25, 2022

This PR tries to fix #2944

@kt3k kt3k requested review from bartlomieju and cjihrig November 25, 2022 11:28
cjihrig
cjihrig approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels wrong, but it does get the CI passing again, so LGTM

@kt3k
Copy link
Member Author

kt3k commented Nov 26, 2022

This feels wrong, but it does get the CI passing again, so LGTM

Thanks! 🙏 Yeah, let's revisit soon.

@kt3k kt3k merged commit 5f5413d into denoland:main Nov 26, 2022
@kt3k kt3k deleted the test-fix-http-client branch November 26, 2022 09:41
cjihrig added a commit that referenced this pull request Nov 28, 2022
@cjihrig
Revert "test(node/http): modify writable of ClientRequest (#2945)" (#…
2947541 
…2950)

This reverts commit 5f5413d.

This change was made in response to
denoland/deno#16616. However, that change
was reverted in denoland/deno#16839 due
to it breaking Vite. Let's revert it here as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node compat test parallel/test-http-outgoing-finish-writable.js fails
2 participants
@kt3k @cjihrig