Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(streams): move to single-export files #2957

Merged
merged 1 commit into from
Nov 29, 2022
Merged

refactor(streams): move to single-export files #2957

merged 1 commit into from
Nov 29, 2022

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Nov 29, 2022

This is part of #2936, which aims for leaner dependencies and a more straightforward structure by only having one export per file within the streams module.

@iuioiua iuioiua marked this pull request as ready for review November 29, 2022 11:21
@iuioiua iuioiua requested a review from kt3k as a code owner November 29, 2022 11:21
@cjihrig cjihrig merged commit 5dabeb2 into denoland:main Nov 29, 2022
@iuioiua iuioiua deleted the refactor-streams branch November 29, 2022 17:18
@kt3k
Copy link
Member

kt3k commented Dec 14, 2022

I feel that streams/mod.ts is a little unfinished. Do we deprecate this file, or keep it as an entrypoint of streams?

@iuioiua
Copy link
Contributor Author

iuioiua commented Dec 14, 2022

I feel that streams/mod.ts is a little unfinished. Do we deprecate this file, or keep it as an entrypoint of streams?

I agree. I'll submit a cleanup PR shortly. That was one of the first restructures I did. I think my approach now is much better.

We should keep mod.ts as an entry point for the module and not deprecate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants