refactor(archive): move to single-export files #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want |
kt3k
reviewed
Nov 30, 2022
Comment on lines
+38
to
+40
| /** @deprecated (will be removed after 0.169.0) TODO: export all once overlapping objects/types are removed */ | ||
| export { Tar, type TarData, type TarDataWithSource } from "./tar.ts"; | ||
| export * from "./untar.ts"; |
There was a problem hiding this comment.
mod.ts doesn't exist now. Does it make sense to add these deprecated versions here?
There was a problem hiding this comment.
Previously, tar.ts acted as the module entry point. Now that Tar and Untar classes have been separated, mod.ts acts as the entry point for both classes.
There was a problem hiding this comment.
It'll also provide a module description where one currently doesn't exist for std/archive.
hmm both seem having examples: I'm ok with either way. |
|
Ok, I'll leave it as is then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #2936, which aims for leaner dependencies and a more straightforward structure by only having one export per file within the archive module.